search

openopt / copt

A Python library for mathematical optimization
http://openo.pt/copt
Other
135 stars 35 forks source link

DOC: Tweaks to documentation, and added mypy to gitignore. #78

Closed FedericoV closed 3 years ago

FedericoV commented 3 years ago

Fixed the documentation for minimize_three_split. There are still a few very minor issues: the verbose flag is currently not used anywhere in the function, and ls_tol on line 149 is potentially unbound - I don't think this is likely reachable in practice though.

fabianp commented 3 years ago

thanks for the contribution!

FedericoV commented 3 years ago

Ooops, yes, typo.

On Tue, Jul 28, 2020 at 9:10 AM Fabian Pedregosa notifications@github.com wrote:

@fabianp commented on this pull request.

In copt/splitting.py https://github.com/openopt/copt/pull/78#discussion_r461701763:

@@ -99,29 +102,29 @@ def minimize_three_split(

 if prox_1 is None:
  • def prox_1(x, s):
  • def prox_1(x, s, args):

why not *args as in prox_2? is it a typo?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/openopt/copt/pull/78#pullrequestreview-456791262, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEZ25SBEMINIUF2AAJ5EA3R53Z7NANCNFSM4PJ65ABQ .

fabianp commented 3 years ago

great, fixed and merged