openopus-org / concertmaster_player

Classical music front-end for Spotify (Player)
GNU General Public License v3.0
53 stars 6 forks source link

Add "undo" and "cancel" buttons to verify area #26

Open tyrann0us opened 4 years ago

tyrann0us commented 4 years ago

Actions in the "verify" section in the expanded "Now playing" section can be destructive, such as reporting a work as "Wrong work", which removes it from the catalog for all users.

No confirmation is required when you click this button, and there is no way to undo if you clicked it by mistake.

Also, no confirmation is required if you submit metadata changes in the "Complete but missing information" view (and maybe other views too).

Lastly, this view should contain a "Back" button. Edit: I just realized that the textarea label (e.g. Thanks for your collaboration! Edit the performers in the field below. One per line. Specify their roles (instrument, voice etc) after commas.) is clickable and acts as a back button. It is not obvious that the label behaves like this before you clicked on it. A button should be added and the function removed from the label.

adrianosbr commented 4 years ago

You’re totally right. I’ll create tasks based on this report. Thanks!

On Wed, 22 Jul 2020 at 08:33 Philipp Bammes notifications@github.com wrote:

Actions in the "verify" section in the expanded "Now playing" section can be destructive, such as reporting a work as "Wrong work", which removes it from the catalog for all users.

No confirmation is required when you click this button, and there is no way to undo if you clicked it by mistake.

Also, no confirmation is required if you submit metadata changes in the "Complete but missing information" view (and maybe other views too).

Lastly, this view should contain a "Back" button.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openopus-org/concertino_player/issues/8, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVDHSC2WNPLQC5OTAT7XLLR43E65ANCNFSM4PETSERA .

-- []s! Adriano.