search

openownership / bods-dev-handbook

Guidance for BODS schema development and related things
https://openownership.github.io/bods-dev-handbook
Apache License 2.0
4 stars 1 forks source link

format validation for invalid files #63

Open odscrachel opened 4 months ago

odscrachel commented 4 months ago

In the list of validation keywords format isn't an option. I couldn't get an invalid test to work with an incorrect uri without using format in the expected_errors.csv. I can see though that format isn't listed in https://json-schema.org/draft/2020-12/meta/validation so I'm not sure if this is correct or what keyword to use instead?

kathryn-ods commented 4 months ago

I think format is the correct one to use here

kd-ods commented 4 months ago

It looks like format validation is a special case in json schema, and doesn't work by default. But I think @rhiaro has set things up so that we can enforce format constraints.

Assigning to @rhiario to confirm that we're correctly using the 'format' keyword in the list of expected errors, and that we should edit the handbook to add it.