openownership / cove-bods

Check that your data complies with the Beneficial Ownership Data Standard (BODS) using our open source data review tool
https://datareview.openownership.org/
Other
4 stars 2 forks source link

Edit Additional checks messages #105

Open kd-ods opened 6 days ago

kd-ods commented 6 days ago

Currently this is how the validation errors look:

Image

The additional checks are much more muted and do not share the same message style and formatting:

Image

We should bring the content and style of the additional checks into line with the validation errors.

kd-ods commented 6 days ago

It looks like there are around 75 addition check messages in https://github.com/openownership/cove-bods/blob/addbods04/cove_bods/templates/cove_bods/additional_checks_table.html.

I've agreed with @radix0000 that I'll edit the messages in the template on a branch which radix0000 will create. (The branch will be deployed and usable so that I can check that I don't break the template with any edits.)

@radix0000 - Here is the edit for the first message in the template:

From:

                <td>
                    {% trans 'The statement has an identifier scheme which is not valid.'  %}
                </td>
                <td>
                    {% trans 'Invalid Scheme' %}: {{ additional_check.scheme }}
                </td>
                <td>
                    {{ additional_check.entity_statement }}
                </td>

To:

                <td>
                    {% blocktrans %}<code>scheme</code> is not valid. Check the BODS documentation for guidance on identifiers. {%endblocktrans%}
                </td>
                <td>
                    <code>scheme</code>: {{ additional_check.scheme }}
                </td>
                <td>
                    {{ additional_check.entity_statement }}
                </td>