search

openownership / data-standard-sphinx-theme

Documentation theme for the Beneficial Ownership Data Standard.
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Rebrand BODS site to match OO styles #57

Closed Lathrisk closed 4 years ago

Lathrisk commented 4 years ago

56

Read the Docs demo page: http://standard.openownership.org/en/56-theme-rebranding/index.html

Lathrisk commented 4 years ago

WIP Changes

Landing page:

Before:

BODS-Existing

After:

BODS-Rebrand

Random Page:

Before:

BODS-Page

After:

BODS-Page2

Lathrisk commented 4 years ago

@stevenday

I've included screenshots of some of the new changes, but expect I need a little input on some of them. For example, with the OO logo in the header, there is less width for the (long) title "Beneficial Ownership Data Standard" so I abbreviated to BODS. An alternative might be adjusting the layout of the header or losing the logo at certain widths.

The ticket also suggests putting the larger OO logo on the homepage somewhere with "tba" beside it, so I've not added it anywhere yet.

I also wondered about expected timescales for this work but we can always discuss that tomorrow.

WIP Changes:

Desktop width landing page:

BODS-Desktop-Landing

Mobile width landing:

BODS-Mobile-Landing

BODS Primer (nav changes):

BODS-Primer-Desktop

stevenday commented 4 years ago

@Lathrisk - I think this is looking great. From these screenshots I'd say you're pretty much done :)

On the specific points:

The ticket also suggests putting the larger OO logo on the homepage somewhere with "tba" beside it, so I've not added it anywhere yet.

The tba was just about the location really - I was thinking in the left sidebar on desktop, perhaps above the title on mobile? On the register we add a small tagline to the logo:

Screenshot 2020-02-17 at 12 06 16

Something similar might also work here?

there is less width for the (long) title "Beneficial Ownership Data Standard" so I abbreviated to BODS. An alternative might be adjusting the layout of the header or losing the logo at certain widths.

I don't think we should abbreviate here, is it difficult to push the title onto two lines like:

Beneficial Ownership
Data Standard

If so, losing the logo is probably preferable, especially if we get it in on the homepage anyway.

I also wondered about expected timescales for this work but we can always discuss that tomorrow.

Yep, happy to review this in more depth tomorrow, but as-per above I think we're nearly there. Obviously if you feel there's more work to do, please flag!

Is it possible to get a staging site set up so that we can get non-technical members of the team to review too?

Lathrisk commented 4 years ago

The demo site is now available at - http://standard.openownership.org/en/56-theme-rebranding/index.html

timgdavies commented 4 years ago

Thanks @Lathrisk: theme is looking really good.

My only concern is about navigation back to the main Open Ownership website.

I think we do need some way for people to find their way back... but I'm not sure what that is right now. @stevenday may have an idea, but if you can think of any good options to suggest -that's welcome too.

Lathrisk commented 4 years ago

@timgdavies at present the Open Ownership logos in the sidebar on desktop and burger nav dropdown on mobile provide a link back to the main OO page. I can have a think about making that more explicit though.

timgdavies commented 4 years ago

Ah-ha - I needed to do a hard refresh. Forgot that RTD seems to need that at times.

Ok - that works for me for now :) I'll leave @stevenday to do the proper review - but I'm happy :)

Lathrisk commented 4 years ago

Thanks, @stevenday, I'll take a look at these changes soon. They all look reasonable and shouldn't take long.

Editing the SVG like you suggested is actually how I changed it from blue to white in the first place. I can't remember what my reason for that was, possibly contrast, but it is a deviation from the Open Ownership website.

Lathrisk commented 4 years ago

@stevenday is this the kind of layout you were thinking of?

(EDIT: all these changes are on the demo site now - http://standard.openownership.org/en/56-theme-rebranding/index.html)

bods-home

Would you prefer the OO logo above or below the version number in the sidebar? Conscious that the blue logo repeats quite close together.

And this for the SVGs?

primer-svg-update

stevenday commented 4 years ago

@stevenday is this the kind of layout you were thinking of?

@Lathrisk - yes, I think that's fine in the first screenshot - under the version number.

Yesterday, @timgdavies had the idea that we could also add an explicit text link under the OO logo which reads "Back to main site", (in the same font/size etc as the nav links) would it be ok to add that in?

And this for the SVGs?

They all look good to me except this:

Screenshot 2020-02-19 at 14 19 52

Which is at the bottom of this page: http://standard.openownership.org/en/56-theme-rebranding/primer/whatisthebods.html

Just to double check, have you applied the same change to the Russian language SVGs? (I don't seem to be able to switch to Russian on the branch preview).

Lathrisk commented 4 years ago

@stevenday ah, I missed that one (json). I think they're all slightly different variants of the same colour because it was a string replacement.

And yes, adding a little text under the logo shouldn't be a problem. I'll group the logo and text into a single link.

I did update the Russian SVGs as well but I've not tested them. I've not looked at the translation stuff much yet but will do some investigation.

Lathrisk commented 4 years ago

@stevenday @timgdavies I've added the 'Back to main site' tagline - http://standard.openownership.org/en/56-theme-rebranding/

(P.S. There seem to be some github issues, so things haven't been updating quite right)

stevenday commented 4 years ago

Thanks @Lathrisk! I'm really nit-picking now, but could we have a bit more space between the logo and the link? A bottom margin on the image seems to do the trick:

Screenshot 2020-02-20 at 08 32 39

I also added a sans-bold class, made the text white and 0.9rem in that, to match the main navigation.

Lathrisk commented 4 years ago

@stevenday I've added those latest changes to the test site. I'll be on other projects until Tuesday now, but I can pick any additional changes/feedback on Tuesday morning.

Lathrisk commented 4 years ago

Thanks @stevenday I'll take a look at these next week. We can definitely drop some fonts, if page weight is a concern then we should also think about minifying assets as part of the build pipeline. That was one on my tech debt shortlist. I think I only have 1 day for BODS work next week in this block, but should be able to rattle through a fair bit of this.

stevenday commented 4 years ago

if page weight is a concern then we should also think about minifying assets as part of the build pipeline. That was one on my tech debt shortlist. I think I only have 1 day for BODS work next week in this block, but should be able to rattle through a fair bit of this.

I'm not overly concerned at the moment, I just thought it wasn't worth adding anything new unnecessarily. That said, I think this is a good thing to add a ticket for, so I've made a placeholder: https://github.com/openownership/data-standard-sphinx-theme/issues/60 - would you mind filling that out with some basic ideas of what you'd like to do @Lathrisk?

stevenday commented 4 years ago

Just a note FYI @Lathrisk - I've fixed a small bug where we hadn't removed the fonts from the main layout html (in ce2d851)

stevenday commented 4 years ago

I've rebased this over master and squashed my fixup at the same time.