search

openownership / data-standard-sphinx-theme

Documentation theme for the Beneficial Ownership Data Standard.
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Branches: 0.1.0-theme & for-standard-v0-1 #75

Open odscjames opened 2 years ago

odscjames commented 2 years ago

We have both these branches.

Commit https://github.com/openownership/data-standard/commit/6214029134d2b0dbe38f58dfc10cf70ba6c69725 changes which one is used.

I'm not clear what the situation is here:

Assigning to @rhiaro as she did the new branch work

rhiaro commented 2 years ago

That's weird. I remember needing to pin 0.1.0 to a point before which certain changes were made that might have adversely affected the 0.1.0 docs (ie. version upgrades to something that weren't compatible with a different version of python in the rtd config) before I could make the html change we needed for the automatic version warning to show.. but I don't remember seeing or interacting with the for-standard-v0-1 branch. I may have made a bad assumption about what the 0.1.0 docs were pinned to. The 0.1.0-theme branch is definitely ahead of for-standard-v0-1 (by a couple of years) and I'm pretty sure I audited it for any potentially breaking commits when I was choosing the best point to pin it with the update.

kathryn-ods commented 2 months ago

I was also wondering today whether for-standard-v0-1 and 0.1.0-theme are both needed - if so we might want to protect these branches.