openownership / data-standard-sphinx-theme

Documentation theme for the Beneficial Ownership Data Standard.
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Version warning not appearing on ReadTheDocs for BODS v0.2.0 #81

Open kd-ods opened 2 years ago

kd-ods commented 2 years ago

We've just release BODS v0.3.0.

When visiting v0.1.0 the version warning appears. When visiting v0.2.0 it doesn't appear.

@rhiaro did some work to enable the ReadTheDocs version banner within the site. Basically this added role="main" to a div at the top of the page. I can't see that role attribute on the div in the v0.2.0 page.

@rhiaro - is there something else we need to do to make the banner appear? (Assigning to @odscjames too, since he's working on BODS atm and may be able to do the legwork if helpful.)

odscjames commented 2 years ago

I think answer is:

BODS 0.2 Locks the theme to the commit before Amy's commit to fix this: 8b05124bd0c5aae102a0f60f892d4d9fb83e9b4b

Maybe if someone upgraded the locked version in 0.2 and hence let RTD rebuild the site it would be fine?


Additional problem noticed while working on this:

0.2.0 locks version of the theme - good! https://github.com/openownership/data-standard/blob/0.2.0/requirements.txt#L8

0.3.0 does not! https://github.com/openownership/data-standard/blob/0.3.0/requirements.txt#L7 When did this happen? Looks like when we switched to compile tools?

We need to sort this, and maybe this is something in favour of just merging the repositories?

Moved to https://github.com/openownership/data-standard/issues/459

kd-ods commented 2 years ago

Thanks for taking a look at this @rhiaro and @odscjames .

kathryn-ods commented 2 months ago

Just checked and this has been resolved as of 0.4 - all versions are showing a warning message

kathryn-ods commented 2 months ago

Actually this isn't resolved.

There is a warning message showing on https://standard.openownership.org/en/0.2.0/schema/index.html

But the warning message isn't showing on https://standard.openownership.org/en/0.2.0/index.html