kathryn-ods commented 7 months ago

Overview

What does this pull request do? adds in some new example data and updates the examples page
How can a reviewer test or examine your changes?
Who is best placed to review it?

Closes #

Translations

[ ] New or edited strings appearing as a result of this PR will be picked up for translation
[ ] I've notified the translation coordinator of any new strings that will need translating. See: https://openownership.github.io/bods-dev-handbook/translations.html

[ ] I've checked that the documentation builds without failing. See: https://github.com/openownership/data-standard#building-the-documentation-locally
[ ] I've thought about how and when this needs to be released. See: https://openownership.github.io/bods-dev-handbook/standard_releases.html
[ ] I've updated the changelog, if necessary.
[ ] I've updated reference.rst to reflect any changes to schema structure or naming.
[ ] I've added or edited any other related documentation. See: https://github.com/openownership/bods-dev-handbook/blob/master/style_guide.md

kathryn-ods commented 7 months ago

Ready for re-review - one question should the headers for tecido/fermcat be more descriptive rather than company names?

kd-ods commented 7 months ago

should the headers for tecido/fermcat be more descriptive rather than company names?

Yes. Take a look in the unresolved conversations... I made a suggestion yesterday :-)

kathryn-ods commented 6 months ago

@kd-ods I've tried putting those timelines into a table format so it's a bit more structured - what do you think?