kathryn-ods commented 3 months ago

Overview

What does this pull request do? updates example data - componentRecords fields were listing statementIds, now they list recordIds

How can a reviewer test or examine your changes?

Who is best placed to review it?

Closes #

Translations

[ ] New or edited strings appearing as a result of this PR will be picked up for translation
[ ] I've notified the translation coordinator of any new strings that will need translating. See the Handbook

[ ] I've checked that the documentation builds without failing. See the Handbook
[ ] I've thought about how and when this needs to be released. See the Handbook
[ ] I've updated the changelog, if necessary. See the Handbook
[ ] I've updated reference.rst to reflect any changes to schema structure or naming.
[ ] I've added or edited any other related documentation. See the Handbook

kd-ods commented 3 months ago

@kathryn-ods - you can remove your changes to examples/bods-package-fi-soe.json from this PR, since I fixed the component recordId in PR #727

kathryn-ods commented 2 months ago

@kathryn-ods - you can remove your changes to examples/bods-package-fi-soe.json from this PR, since I fixed the component recordId in PR #727

Have done this now and re-requested a review

kathryn-ods commented 2 months ago

having an issue with the link check tests - https://www.iso20022.org/market-identifier-codes showing as broken

kathryn-ods commented 2 months ago

ok I removed and readded the link and that seems to have worked

kd-ods commented 2 months ago

@kathryn-ods - I'll take a look at this Wed.