openownership / data-standard

The Beneficial Ownership Data Standard (BODS) is an open standard providing a specification for modelling and publishing information on the beneficial ownership and control of corporate vehicles

http://standard.openownership.org

Other

63 stars 13 forks source link

Example drt main #735

Open kathryn-ods opened 3 days ago

kathryn-ods commented 3 days ago

Overview

What does this pull request do? Makes minor fixes to the examples files, identified by the DRT

How can a reviewer test or examine your changes? Run a few through the DRT to check they're fine

Who is best placed to review it?

Closes #

Translations

[ ] New or edited strings appearing as a result of this PR will be picked up for translation
[ ] I've notified the translation coordinator of any new strings that will need translating. See the Handbook

Documentation & Release

[ ] I've checked that the documentation builds without failing. See the Handbook
[ ] I've thought about how and when this needs to be released. See the Handbook
[ ] I've updated the changelog, if necessary. See the Handbook
[ ] I've updated reference.rst to reflect any changes to schema structure or naming.
[ ] I've added or edited any other related documentation. See the Handbook

kathryn-ods commented 3 days ago

@kd-ods in addition to the fixes here all examples had the error

beneficialOwnershipOrControl expected to be 'true' in at least one Relationship statement with a person as an interested party. If this dataset contains beneficial owners, check that beneficialOwnershipOrControl is correctly used.

Do we need to fix this?

kathryn-ods commented 3 days ago

I'm not sure why the docs linkcheck keeps breaking - I haven't made any docs changes so it shouldn't be. I think there's some sort of issue with the way it interacts with the ISO site.

kd-ods commented 2 days ago

@kd-ods in addition to the fixes here all examples had the error

beneficialOwnershipOrControl expected to be 'true' in at least one Relationship statement with a person as an interested party. If this dataset contains beneficial owners, check that beneficialOwnershipOrControl is correctly used.

Do we need to fix this?

I don't think we need to change the example files.

(It's a bit of an anomalous type of error message... since it's not an error, as such. It's a prompt for users of the tool to check that they are correctly using that field IF their dataset contains beneficial owners. There are definitely improvements to the user interface of the Data Review Tool which could make that clearer.)