search

openownership / lib-cove-bods

Check that your data complies with the Beneficial Ownership Data Standard (BODS) using our install our data review library to analyse files via your command line interface
https://datareview.openownership.org/
Other
1 stars 0 forks source link

Updated check: version number #124

Open kathryn-ods opened 4 weeks ago

kathryn-ods commented 4 weeks ago

Currently in cove as inconsistent_schema_version_used this needs to be rewritten to allow for inconsistent minor versions.

Check: all Statements MUST have the same major version number.

On fail:

Error message: Statements have different major version numbers. Info message: Version number (bodsVersion): [VALUE], Version number (bodsVersion): [VALUE2]

kathryn-ods commented 4 weeks ago

@radix0000 does it make sense to implement this test at this point in time? Because it's only invalid if the major values don't match one of the invalid values would need to include a statement with e.g. "1.0" and "0.4" as 1.0 doesn't exist yet would that be flagged up for not being a valid bods version as well as having inconsistent values?

kathryn-ods commented 3 weeks ago

@kd-ods you might be able to advise on the above now you're back