openownership / lib-cove-bods

Check that your data complies with the Beneficial Ownership Data Standard (BODS) using our install our data review library to analyse files via your command line interface
https://datareview.openownership.org/
Other
1 stars 0 forks source link

Annotations with pointer "/" are flagged as invalid #136

Closed kathryn-ods closed 12 hours ago

kathryn-ods commented 15 hours ago

Additional Checks - "An annotation on this Statement does not have a valid JSON pointer in statementPointerTarget."

Sample -

      {
        "motivation": "commenting",
        "description": "LEI Registration Status: ISSUED",
        "statementPointerTarget": "/",
        "creationDate": "2024-08-12",
        "createdBy": {
          "name": "Open Ownership",
          "uri": "https://www.openownership.org"
        }
      }
    ]

We sometimes use "/" to apply to an entire statement - our own documentation actually says to use an empty string in this case so maybe we actually need to just correct these instances.

Full example to replicate

[
  {
    "source": {
      "type": [
        "officialRegister",
        "verified"
      ],
      "assertedBy": [
        {
          "name": "GLEIF"
        }
      ],
      "url": "https://goldencopy.gleif.org/storage/golden-copy-files/2024/06/06/940025/20240606-0000-gleif-goldencopy-repex-golden-copy.csv.zip"
    },
    "statementDate": "2024-06-06",
    "annotations": [
      {
        "motivation": "commenting",
        "description": "LEI Registration Status: ISSUED",
        "statementPointerTarget": "/",
        "creationDate": "2024-08-12",
        "createdBy": {
          "name": "Open Ownership",
          "uri": "https://www.openownership.org"
        }
      }
    ],
    "publicationDetails": {
      "publicationDate": "2024-08-12",
      "bodsVersion": "0.4",
      "license": "https://creativecommons.org/publicdomain/zero/1.0/",
      "publisher": {
        "name": "Open Ownership",
        "url": "https://www.openownership.org"
      }
    },
    "recordId": "001GPB6A9XPE8XJICC14",
    "declarationSubject": "001GPB6A9XPE8XJICC14",
    "recordStatus": "new",
    "recordType": "entity",
    "recordDetails": {
      "entityType": {
        "type": "registeredEntity"
      },
      "name": "Fidelity Advisor Leveraged Company Stock Fund",
      "jurisdiction": {
        "name": "United States",
        "code": "US"
      },
      "isComponent": false,
      "identifiers": [
        {
          "id": "001GPB6A9XPE8XJICC14",
          "scheme": "XI-LEI",
          "schemeName": "Global Legal Entity Identifier Index"
        },
        {
          "id": "S000005113",
          "schemeName": "RA000665"
        }
      ],
      "addresses": [
        {
          "type": "registered",
          "address": "245 SUMMER STREET, BOSTON",
          "country": {
            "name": "United States",
            "code": "US"
          },
          "postCode": "02210"
        },
        {
          "type": "business",
          "address": "C/O FIDELITY MANAGEMENT & RESEARCH COMPANY LLC, WILMINGTON",
          "country": {
            "name": "United States",
            "code": "US"
          },
          "postCode": "19801"
        }
      ],
      "foundingDate": "2012-11-29"
    },
    "statementId": "XI-LEI-001GPB6A9XPE8XJICC14-20240606"
  }
]
kathryn-ods commented 12 hours ago

Closed as this is actually an issue with the data