openownership / lib-cove-bods

Check that your data complies with the Beneficial Ownership Data Standard (BODS) using our install our data review library to analyse files via your command line interface
https://datareview.openownership.org/
Other
1 stars 0 forks source link

Death date error message #142

Open kathryn-ods opened 12 hours ago

kathryn-ods commented 12 hours ago

This is invalid because the death date is 190 years after birth date but the error message doesn't include this as a possibility.

deathDate` is incorrect. Check that the date is not before the birthDate or in the future.

I think we need to say "death date more than 120 years after birth date" or something as well

[
  {
    "statementId": "019a93f1-e470-42e9-957b-03559861b2e2",
    "declarationSubject": "c359f58d2977",
    "statementDate": "2020-03-04",
    "recordId": "10478c6cf6de",
    "recordType": "person",
    "recordDetails": {
      "isComponent": false,
      "personType": "knownPerson",
      "birthDate": "1800",
      "deathDate":"1990-05-01"
    }
  }
]
kd-ods commented 10 hours ago

What about changing the message to: "...Check that the date is not before the birthDate, in the future, or humanly impossible." I'm only half-joking.