New validation check: address types should match descriptions in schema

openownership / lib-cove-bods

Check that your data complies with the Beneficial Ownership Data Standard (BODS) using our install our data review library to analyse files via your command line interface

https://datareview.openownership.org/

Other

1 stars 0 forks source link

New validation check: address types should match descriptions in schema #22

Closed ScatteredInk closed 5 years ago

ScatteredInk commented 5 years ago

To spec properly later but:

some address types are only associated with natural persons;
some address types are only associated with legal entities;
addresses with type alternative must be accompanied with another primary address.

kd-ods commented 5 years ago

Here's the spec. We need to validate that:

If Address.type is 'placeOfBirth', 'residence', or 'service', then the parent statement is a Person Statement.
if Address.type is 'registered', or 'business' then the parent statement is an Entity Statement.
if Address.type is 'alternative' then the parent Statement contains at least one other Address object with type not 'alternative'.

odscjames commented 5 years ago

It looks like this should only be checked on 0.2 data?

kd-ods commented 5 years ago

Yes, this only needs to be checked for 0.2.

odscjames commented 5 years ago

Having read the draft spec carefully, I think I'm safe in rewriting the first two points to:

A person statement should only have addresses of type 'placeOfBirth', 'residence', or 'service', or 'alternative'
A Entity statement should only have addresses of type 'registered', or 'business' or 'alternative'
Third point as above

odscjames commented 5 years ago

issue22a issue22b issue22c issue22d

Ok?

kd-ods commented 5 years ago

Looks good. I'll leave you to close it @odscjames

odscjames commented 5 years ago

This has now been merged to master in cove and is just waiting for a deploy.