search

openownership / lib-cove-bods

Check that your data complies with the Beneficial Ownership Data Standard (BODS) using our install our data review library to analyse files via your command line interface
https://datareview.openownership.org/
Other
1 stars 0 forks source link

New validation check: isComponent part 1 #23

Closed kd-ods closed 5 years ago

kd-ods commented 5 years ago

If an entity, person or ooc statement has isComponent value ‘true’ check that there is a primary ooc Statement which references it (by statementID) from the primary’s componentStatementIDs property.

odscjames commented 5 years ago

To expand the definition a bit to be clear about primary ooc:

If an entity, person or ooc statement has isComponent value ‘true’ check that there is another ooc Statement with isComponent value ‘false’ which references it (by statementID) from the componentStatementIDs property.

And to add part 2 from https://github.com/openownership/lib-cove-bods/issues/24

If an entity, person or ooc statement has isComponent value ‘true’ check that there is another ooc Statement later in the document with isComponent value ‘false’ which references it (by statementID) from the componentStatementIDs property.

kd-ods commented 5 years ago

Yes. We think it's more informative to keep #23 and #24 as separate checks.

odscjames commented 5 years ago

issue23

Ok?

Not sure if we should cover the "primary" check in there somewhere?

kd-ods commented 5 years ago

Please rephrase to "This Ownership-or-control Statement is a component (isComponent) but no primary Ownership-or-control Statement references it (from componentStatementIDs)".

odscjames commented 5 years ago

Done

odscjames commented 5 years ago

This has now been merged to master in cove and is just waiting for a deploy.