search

openownership / lib-cove-bods

Check that your data complies with the Beneficial Ownership Data Standard (BODS) using our install our data review library to analyse files via your command line interface
https://datareview.openownership.org/
Other
1 stars 0 forks source link

New validation check: componentStatementIDs part 2 #26

Closed kd-ods closed 5 years ago

kd-ods commented 5 years ago

If oocStatement.componentStatementIDs contains any statementIDs, check that oocStatement.isComponent is ‘false’.

odscjames commented 5 years ago

Doing this as a check for "any statementIDs" so an empty list is fine?

odscjames commented 5 years ago

(The other option is that the componentStatementIDs key just should not exist at all, but you might get some software that writes out a empty list by default maybe)

ScatteredInk commented 5 years ago

That sounds fine. We may check for minItems in the schema later.

odscjames commented 5 years ago

issue26

Ok?

kd-ods commented 5 years ago

Please rephrase to "An Ownership-or-control Statement cannot both be a component statement (isComponent) and have component statements (componentStatementIDs)."

Thanks!

odscjames commented 5 years ago

Done

odscjames commented 5 years ago

This has now been merged to master in cove and is just waiting for a deploy.