search

openownership / lib-cove-bods

Check that your data complies with the Beneficial Ownership Data Standard (BODS) using our install our data review library to analyse files via your command line interface
https://datareview.openownership.org/
Other
1 stars 0 forks source link

Replace test data with fictitious examples #42

Open siwhitehouse opened 4 years ago

siwhitehouse commented 4 years ago

The current test data in https://github.com/openownership/lib-cove-bods/tree/master/tests/fixtures has examples of actual companies. In line with our other CoVE instances and the BODS standard website we should replace this test data with fictitious people and companies.

siwhitehouse commented 4 years ago

This was copied across from Open Data Services' (internal) issue http://bods.opendataservices.coop/redmine/issues/563

odscjames commented 4 years ago

Can we be clear what data needs to be removed? Thanks.

Noting that a standard pull request will mean that the data will still be available in the usual git history. We can rewrite history to remove the data fully, but that will take much more time and cause issues for anyone else with checked out versions.

stevenday commented 4 years ago

Discussing this, it's just Chris Taggarts details, so we can just remove it now and not worry about the git rewrite.

ScatteredInk commented 4 years ago

This test data file is also a real company/person: https://github.com/openownership/data-standard/blob/master/tests/data/bods-package/valid/valid-bods-package-linking-annotations.json

kd-ods commented 3 months ago

This will be removed for BODS 0.4 tests and beyond.