openownership / lib-cove-bods

Check that your data complies with the Beneficial Ownership Data Standard (BODS) using our install our data review library to analyse files via your command line interface
https://datareview.openownership.org/
Other
1 stars 0 forks source link

Release 0.6.0; Changes to packaging only; #54

Closed odscjames closed 4 years ago

odscjames commented 4 years ago

Also

odscjames commented 4 years ago

So this is ok, but I had to remove 2 tests to make this work. Would like to find out why

Bjwebb commented 4 years ago

jsonschema has optional dependencies: rfc3987 and strict-rfc3339, which are required to validate URIs and date-times. In this PR they are no longer installed directly by lib-cove-bods, which makes sense, but instead they should be dependencies of lib-cove. I'll create a pull request there.

Bjwebb commented 4 years ago

I've made a lib-cove PR https://github.com/OpenDataServices/lib-cove/pull/48

Bjwebb commented 4 years ago

This now requires the latest lib-cove, so that we get those optional dependencies of jsonschema.

I think this is now ready to merge. @stevenday could you check?

Bjwebb commented 4 years ago

I've updated the README. I've removed the FAQ, and moved the installation steps further up, so hopefully people shouldn't run into that same issue any more.