search

openownership / lib-cove-bods

Check that your data complies with the Beneficial Ownership Data Standard (BODS) using our install our data review library to analyse files via your command line interface
https://datareview.openownership.org/
Other
1 stars 0 forks source link

Issues running with libcove 0.19.0 #61

Closed stevenday closed 3 years ago

stevenday commented 3 years ago

I've run into an issue today where my fresh installation of lib-cove-bods 0.8.0 cannot run on the CLI because of a missing config attribute on the SchemaBODS object.

It seems config was recently introduced in lib-cove 0.19.0 and it gets installed because lib-cove-bods specifies >= 0.18.0 in setup.py

As a temporary workaround I can specify libcove==0.18.0 in my requirements.txt to make sure I get a compatible version, but it seems like we either need to fix the incompatibility or pin the version more strictly. I suspect the latter won't affect anyone, you're only likely to have libcove because of libcovebods, so perhaps that's a good idea anyway?

Bjwebb commented 3 years ago

Sorry, I missed that this would break compatibility. The change to lib-cove-bods should be quite straightforward, so I'll take a look over the next few days.

Bjwebb commented 3 years ago

There's some more breaking changes in 0.20.0, so my suggestion is we pin for now, see https://github.com/openownership/lib-cove-bods/pull/63