New additional check type, "statement_is_beneficialOwnershipOrControl_but_no_person_specified" - Githubissues

openownership / lib-cove-bods

Check that your data complies with the Beneficial Ownership Data Standard (BODS) using our install our data review library to analyse files via your command line interface

https://datareview.openownership.org/

Other

1 stars 0 forks source link

New additional check type, "statement_is_beneficialOwnershipOrControl_but_no_person_specified" #71

Closed odscjames closed 2 years ago

odscjames commented 2 years ago

https://github.com/openownership/lib-cove-bods/issues/47

odscjames commented 2 years ago

Turns out we already have examples of good data here:

https://github.com/openownership/lib-cove-bods/blob/47-check/tests/fixtures/0.1/basic_1.json (person is specified)
https://github.com/openownership/lib-cove-bods/blob/47-check/tests/fixtures/0.2/basic_1.json (person is specified)
https://github.com/openownership/lib-cove-bods/blob/47-check/tests/fixtures/0.1/basic_2.json (no person but it's not beneficialOwnershipOrControl)

Added some bad data:

https://github.com/openownership/lib-cove-bods/blob/47-check/tests/fixtures/0.1/beneficialOwnershipOrControl_but_unspecified_person_1.json (interested party is unspecified)
https://github.com/openownership/lib-cove-bods/blob/47-check/tests/fixtures/0.2/beneficialOwnershipOrControl_but_unspecified_person_1.json (interested party is unspecified)
https://github.com/openownership/lib-cove-bods/blob/47-check/tests/fixtures/0.1/beneficialOwnershipOrControl_but_unspecified_person_2.json (interested party is another entity)

kd-ods commented 2 years ago

The bad data fixtures look good to me, @odscjames.