search

openownership / lib-cove-bods

Check that your data complies with the Beneficial Ownership Data Standard (BODS) using our install our data review library to analyse files via your command line interface
https://datareview.openownership.org/
Other
1 stars 0 forks source link

Statistic: breakdown of use of interest.directOrIndirect #78

Closed kd-ods closed 1 month ago

kd-ods commented 2 years ago

Under the OOC Statements section > Total Interest Statements, add:

(Also, while we're there, can we retitle 'Total Interest Statements' to 'Total Interest objects'.)

odscjames commented 2 years ago

(Also, while we're there, can we retitle 'Total Interest Statements' to 'Total Interest objects'.)

This can apply to all versions - the new stat applies to 0.3 only

Blueskies00 commented 2 years ago

Tests: https://docs.google.com/spreadsheets/d/1RCE3PBKXebSfHdgAKZZhOaE3M-4c3pWMpSNcklF-GYg/edit#gid=339537194

20 direct 5 indirect 1 unknown 1 null

Expected result: To see the above represented in the statistics, with associated percentages. Actual result: All except the null represented. Comments: The %s presented are accurate based on a total of 27 interest objects. As directOrIndirect isn't actually a required field, depending how many statements show null this could be confusing for an inexperienced user who attempts to calculate the numbers. Test: PASSED ACTIONS: @kd-ods is it worth considering including a stat for nulls when present?

P.s. this has been done:

(Also, while we're there, can we retitle 'Total Interest Statements' to 'Total Interest objects'.)

kd-ods commented 2 years ago

@kd-ods is it worth considering including a stat for nulls when present?

Hmmm - in the long run we need to consider when and how we report on null (and non-existent) properties in general. I don't think we should worry about this particular null value for the moment. (And, we might - with a full review of the standard - decide later on to make this a required field anyway,)