search

openownership / lib-cove-bods

Check that your data complies with the Beneficial Ownership Data Standard (BODS) using our install our data review library to analyse files via your command line interface
https://datareview.openownership.org/
Other
1 stars 0 forks source link

Add tests of improved validation error messages for oneOf #8

Closed Bjwebb closed 5 years ago

Bjwebb commented 5 years ago

openownership/cove-bods#16

Depends on this lib-cove PR https://github.com/OpenDataServices/lib-cove/pull/12

odscjames commented 5 years ago

badfile_all_validation_errors.json seems to be a new file but I can't see it actually being used anywhere - have I missed something?

I would put the upgrading of lib-cove to 0.5 in the changelog - we have to make sure that requirement is meet upstream when upgrading openownership/cove-bods and it would be good if it was clear in the Changelog. Also, that produces behaviour change in this repo in the types of error messages approved, it seems worth noting.

Bjwebb commented 5 years ago

badfile_all_validation_errors.json seems to be a new file but I can't see it actually being used anywhere - have I missed something?

Sorry, this is a holdover from the changes I removed from this branch. I have removed it.

I would put the upgrading of lib-cove to 0.5 in the changelog

Done.