search

openownership / openownership.org-wagtail

Open Ownership Wagtail site.
Other
1 stars 1 forks source link

BUG: Search button being cut off on desktop and mobile browsers #384

Closed StephenAbbott closed 1 year ago

StephenAbbott commented 1 year ago

Bug spotted today where the purple 'Search' button at the top of the search page on Open Ownership website is being cut off.

Same behaviour observed across desktop Chrome/Firefox browsers and mobile Chrone/Firefox browsers.

Desktop:

image

Mobile: IMG_7537

Original designs - see Sketch link - show how the full purple search button is supposed to be shown:

image

The search functionality still works when you enter a search term and click on the small visible bit of the purple button, but button should be fixed ASAP.

philgyford commented 1 year ago

@ohhelloana Looks like this is because the button's contents are hidden:

        <button class="btn" type="submit">
          <span class="visually-hidden">{% trans %}Search{% endtrans %}</span>
        </button>

Which looks deliberate so I'm wondering if there's something else not working here, or if it's safe to just remove the <span> and leave the text?

StephenAbbott commented 1 year ago

Signed off ✅