search

openownership / register

A demonstration transnational register of beneficial ownership data from the UK, Denmark, Slovakia and Armenia
https://register.openownership.org
GNU Affero General Public License v3.0
18 stars 3 forks source link

Register v2: post-launch tasks #186

Closed StephenAbbott closed 7 months ago

StephenAbbott commented 1 year ago

For @spacesnottabs and @tiredpixel to spec out and update

tiredpixel commented 1 year ago

Task C4: Configure Review apps on Heroku for Register V2

Configure Heroku openownership-register-v2 pipeline to enable review apps. This will enable Heroku apps to be automatically created for GitHub PRs, enabling functionality for complex pieces of work to be more easily tested prior to merge. The environment variables should be similar to existing stag app, but use the new Elasticsearch and AWS IAM users already created with uat suffix.

It might be worth renaming existing stag app at the same time, to change the URL to the new Heroku format (which includes a random component), and make the suffixes dev, uat, stg, prd (rather than stag or staging).

Estimate: 1h30

tiredpixel commented 1 year ago

Task C5: Turn off dynos for legacy Register application

Now register v2 has been live for some time, decommission the openownership-register (i.e. v1, not v2) pipeline, to shut down dynos and significantly reduce costs. This will involve decommissioning the review, staging, and production apps. Note that this marks the point of no return for rollback to register v1. Also note that URLs for QA have already changed to the new v2 apps, so anything referring to these old apps will need to be updated.

Estimate: 0h30

tiredpixel commented 1 year ago

@StephenAbbott, could I please just double-check that C5 is approved—that is, getting rid of register-v1 on Heroku?

tiredpixel commented 1 year ago

@spacesnottabs, are you able to spec C1, C2, C7, please?

StephenAbbott commented 1 year ago

@tiredpixel Yes. C5 is approved

tiredpixel commented 1 year ago

Thanks, @StephenAbbott. C5 is done; register-v1 is decommissioned.

tiredpixel commented 1 year ago

C4 is done. Review apps will build automatically once PR #193 is in.

tiredpixel commented 1 year ago

@spacesnottabs, when you get some time, I think all that is remaining from this ticket is for you to clarify or spec C1, C2, C7. Thanks!

tiredpixel commented 11 months ago

Spec for remaining tasks (by @spacesnottabs):

Post launch tasks.pdf

tiredpixel commented 10 months ago

Task C7 is blocked by https://github.com/openownership/register/issues/213 . Since nothing on this list is urgent, I'm pausing any work on this until after that ticket, and changing the state of this ticket to reflect that.

tiredpixel commented 7 months ago

Task C1: Configure dev and test buckets if necessary for S3

Currently there is just the single bucket used bu the ingesters and transformers (oo-register-v2).

When testing changes to ingestors or transformers, it would be better for a test (or dev) environment to use different S3 buckets, Elasticsearch indexes, and Kinesis streams.

This should also be done to separate staging from production, as well as for local dev.

tiredpixel commented 7 months ago

Task C2: Configure dev and test settings for S3

This requires updating any necessary config so that review apps for ingesters and transformers will use the new test buckets configured in C1.

tiredpixel commented 7 months ago

Task C7: Cleanup legacy data and buckets on S3 which is no longer required

Quite a lot of test data was produced which is not required.

This task is blocked by first needing to replace the register-files-combiner.

Remove the data in:

S3 bucket and data in:

tiredpixel commented 7 months ago

Since the new Register Files Combiner is complete, this task is no longer blocked by #213 .

tiredpixel commented 7 months ago

Task C7 cleanup is complete. I think there might still be some unused S3 buckets, but if they weren't mentioned here, I didn't delete them.

I did, however, also clean up backups/ in oo-register-v2, and move another file.

tiredpixel commented 7 months ago

Which approach would be best for Tasks C1 and C2 depends rather on the upcoming roadmap. Rather than spend time configuring and testing these for something which might not currently need active development, I suggest that we instead leave those tasks undone, for now, but instead do them when the need arises during future development. In which case, I'd suggest closing this ticket, since it's already quite long after Register 2 release, and there isn't anything important left, from what I can see.

What do you think, @StephenAbbott ? Should we close the ticket and leave Tasks C1 and C2 undone for now?

StephenAbbott commented 7 months ago

Sounds good @tiredpixel. Will close