search

openownership / visualisation-tool

A visualisation library for beneficial ownership structures
https://www.openownership.org/en/publications/beneficial-ownership-visualisation-system/bods-data-visualiser/
Apache License 2.0
19 stars 4 forks source link

Display unknown interestLevel (directOrIndirect) as dotted line #101

Closed Lathrisk closed 2 years ago

Lathrisk commented 2 years ago

https://docs.google.com/document/d/1KyZO8XaRGyAxAtKf0UhbBQuWM6DASb2l310h8J0ewRY/edit?disco=AAAAWjMYxjU

Lathrisk commented 2 years ago

@kd-ods I've been looking into this more. I set the interestLevel/directOrIndirect value to direct because it is not a required field and is often omitted from the data I've checked. There also isn't a codelist but I assumed that this string value would always be direct or indirect. In the case of this issue, that value is actually set to unknown.

I'm not sure what behaviour we want for everything here. In the case mentioned in the Google doc above, the interest has a type and an interestLevel. In this scenario the control edge is drawn to the default thickness, but with no label attached.

Do we want to assume a codelist, for the purpose of the visualiser, of direct, indirect, and unknown?

Happy to have a call if that makes thing easier.

kd-ods commented 2 years ago

There is a codelist (but you may have missed it because of the renaming of the property):

https://github.com/openownership/data-standard/blob/master/schema/codelists/directOrIndirect.csv

So when the field is omitted, let's assume that the value is 'unknown', then format the line on that basis. Will that work?

Lathrisk commented 2 years ago

Thanks, @kd-ods, I'll take a look at this this week. We might need to chat, but I'll do some poking about first.