search

openownership / visualisation-tool

A visualisation library for beneficial ownership structures
https://www.openownership.org/en/publications/beneficial-ownership-visualisation-system/bods-data-visualiser/
Apache License 2.0
20 stars 5 forks source link

Resolve SVG flags issues #90

Closed Lathrisk closed 2 years ago

Lathrisk commented 2 years ago

We have moved to importing SVG files and embedding them into the document to enable the pure SVG download. The flag SVG files we were using are inconsistent and some are proportioned differently and are missing the viewBox parameter.

I intended to replace these with a more consistent alternative.

Lathrisk commented 2 years ago

@kd-ods @StephenAbbott I have added a new set of flags from this repo.

They are far more consistent than the old flag sets. These are either 4x3 or 1x1. I've opted for the 4x3 because they look slightly more natural. There are other options if we want to preserve the original aspect ratio of flags, but a fixed aspect ratio makes the positioning a little easier.

I'm happy to slot in any flag set so long as the SVGs are relatively consistent so if the preference isn't 4x3 I can switch them over.

StephenAbbott commented 2 years ago

@Lathrisk Looks good to me. Also handy to see that there is an unknown flag in that repo too https://github.com/lipis/flag-icons/blob/main/flags/4x3/xx.svg

Lathrisk commented 2 years ago

@StephenAbbott I hadn't noticed that, good spot. At present we don't display anything if we don't know the country. My question would be whether this flag adequately communicates that we don't know what the country is.

I wonder if we should create something that follows the existing pattern that we use elsewhere, i.e. a question mark in the middle of a blank flag. This is the pattern we use for all of the unknown node types.

Or display no flag.

StephenAbbott commented 2 years ago

@Lathrisk Realised I responded too fast. @tymonk @kd-ods, Virgil and I have been having a related discussion over email about the new stateBody icon that Virgil is creating.

We've tried to imagine scenarios where we know which state it is which controls the SOE, but not which body specifically the state controls (due to poor SOE reporting data).

So in line with the BOVS vocabulary, let's follow the existing pattern for unknown node types if there are cases where we'd need to show unknown state.