search

openpatch / hyperbook

Hyperbook is a quick and easy way to build interactive workbooks, that support modern standards and runs superfast.
https://hyperbook.openpatch.org
MIT License
33 stars 7 forks source link

Add Video Element with <video> tag #847

Closed elielmartinsbr closed 9 months ago

elielmartinsbr commented 10 months ago

Hello,

I'm sending this pull request to propose adding a new video component to the project. This component uses the native HTML <video> tag to provide an improved user experience when playing videos.

I tested the new component on several modern browsers on Windows to ensure compatibility.

I believe this new component will add significant value to the project, offering a native solution for video playback. I am open to feedback and suggestions to further improve this implementation.

The motivation to suggest the component arises from the need to add videos to the documentation of an internal process that we are building with Hyperbook.

Please review the changes when possible and let me know if there are any questions or adjustments needed.

Thanks!

Yours sincerely, Eliel Martins

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperbook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 11:57pm
mikebarkmin commented 9 months ago

Looks great. Can you please update the pnpm.lock file by running pnpm i and commting the new file.

elielmartinsbr commented 9 months ago

Looks great. Can you please update the pnpm.lock file by running pnpm i and commting the new file.

Hi, pnpm lock file updated.

mikebarkmin commented 8 months ago

Perfect. Thank you :)