search

openpgp-pqc / draft-openpgp-pqc

Repository of the WIP draft-ietf-openpgp-pqc
Other
8 stars 2 forks source link

Remove NIST and Brainpool curve hybrids #107

Closed wussler closed 3 months ago

wussler commented 3 months ago
TJ-91 commented 3 months ago

Also looks good to me, I think you covered it all.

I think we "needed" the general ECC term mostly for encompassing ECDSA and EdDSA in one term so it makes sense to include this change here when dropping ECDSA. Or did we have another reason for it? If it makes defining separate NIST / Brainpool drafts easier we could keep the more general "ECC" wording but I prefer it like it is now and don't think it will be a problem.

One really minor thing I would change in the Changelog: I wouldn't write "Moved NIST and Brainpool curve hybrids to a separate draft" since we have not yet done it (or have we?)

wussler commented 3 months ago

Here for instance, the renaming "ECC" to "ECDH" or "EdDSA", resp., wasn't really necessary.

True, but we drop the ECDH-KEM (because it was the generic KEM for NIST/Brainpool curves), so we couldn't rename it without the split as it would have overloaded the term.

For ECDSA/EdDSA is what Johannes pointed out, just wanted to be more precise since now we implement only EdDSA.

One really minor thing I would change in the Changelog: I wouldn't write "Moved NIST and Brainpool curve hybrids to a separate draft" since we have not yet done it (or have we?)

I can change it to "Removed NIST and Brainpool curve hybrids" if you think it's a good idea @TJ-91, since from the perspective of this draft this is what's happening.

TJ-91 commented 3 months ago

I can change it to "Removed NIST and Brainpool curve hybrids" if you think it's a good idea @TJ-91, since from the perspective of this draft this is what's happening.

that works for me :+1: