openpgp-pqc / draft-openpgp-pqc

Repository of the WIP draft-ietf-openpgp-pqc
Other
8 stars 2 forks source link

reworked key combiner to be NIST conforming #138

Closed falko-strenzke closed 1 month ago

falko-strenzke commented 2 months ago

This PR brings the following changes:

Fixes #132. Fixes #127.

Once this is approved we will apply the same construction in https://github.com/openpgp-pqc/draft-ehlen-openpgp-nist-bp-comp.

In the meeting on 2024-08-22, we agreed to create new test vectors only before the publication.

Open work items

Before we can remove the draft status, there is one thing that needs checking regarding the test vectors:

falko-strenzke commented 2 months ago

You also replaced SHA3 here:

hex-encoded KMAC256 output is TODO.

I think it is more consistent to then also write multiKeyCombine.

Changed it now also to multiKeyCombine.