search

openpgp-pqc / draft-openpgp-pqc

Repository of the WIP draft-ietf-openpgp-pqc
Other
8 stars 2 forks source link

clarify x25519 wire format #77

Closed dkg closed 4 months ago

dkg commented 7 months ago

draft-ietf-openpgp-pqc-00 currently says:

For Curve25519 this specification adapts the encoding of objects as defined in [RFC7748] in contrast to [I-D.ietf-openpgp-crypto-refresh].

What does this sentence mean? is "adapt" supposed to mean "adopt"? In this context, adapt typically means "modifies to fit", while "adopt" typically means "embraces as specified". the crypto-refresh draft itself uses RFC 7748 for X25519: https://www.ietf.org/archive/id/draft-ietf-openpgp-crypto-refresh-13.html#section-5.1.6 There is of course Curve25519Legacy (https://www.ietf.org/archive/id/draft-ietf-openpgp-crypto-refresh-13.html#section-5.5.5.6.1.1) but that is deprecated and not the recommended approach.

falko-strenzke commented 7 months ago

I think you are entirely right. I am quite sure the text you are referring to was written before the crypto-refresh received the new X25519. I integrated my proposed fix in my recent PR https://github.com/openpgp-pqc/draft-openpgp-pqc/pull/80. Please check if that fixes the issue.

falko-strenzke commented 4 months ago

Closing it as fixed in #80