Closed hs-kgoriunov closed 1 year ago
Any progress / updates on this, and if not, would someone be willing to make any additional needed updates?
@wyardley We're going to release a patch over v0.0.11 which is used by OpenPGP.js v5. However, for the newer releases, we are instead removing support for internal conversions, and we'll only accept WebStreams in input. We should implement that in the next release.
Thanks for investigating the problem and finding the fix @hs-kgoriunov ! I've taken over the PR since we are only going to patch an older version of the lib, as mentioned above 🙂
NodeReadable._destroy()
implementation allowing it to work nicely from withinpipeline()
helperNodeReadable._cancelling
andNodeReadable._reading
this.emit('error', e)
withthis.destroy(e)
as it has a more sophisticated implementation and its usage is recommended by the Node.js docsSee the discussion here https://github.com/openpgpjs/openpgpjs/issues/1512