search

openpgpjs / web-stream-tools

Convenience functions for reading, transforming and working with WhatWG Streams
MIT License
27 stars 15 forks source link

Use '.js' endings in import statements #20

Closed rrrooommmaaa closed 1 year ago

rrrooommmaaa commented 1 year ago

We're having problems loading the script as module the way it is now, so we have to patch it before use. As I understand, it is current standard to have .js explicitly specified in import statements.

larabr commented 1 year ago

Thanks for the proposal. Not sure if it's standard but it's indeed needed for ES6 in Node. To have proper support in this sense, I think we should also add type: "module" to package.json , so that we can also drop the esm flag in tests . cc @twiss : you see any reason not to declare the library as a module?

rrrooommmaaa commented 1 year ago

We're having problems when loading the module in the browser extension with <script type="module" ... > tag