Text search not working

openphacts / GLOBAL

Global project issues [private for now. owner lee harland]

3 stars 0 forks source link

Text search not working #22

Closed leeharland closed 10 years ago

leeharland commented 10 years ago

Two issues: search for phophodiesterase 5a

nothing comes back.

something should go back
if nothing comes back, we should write "no results" in the main search panel.

ChristineChichester commented 10 years ago

This is odd behavior because in the Open PHACTS API and the conceptwiki itself there are results for phoshodiesterase 5a...

danidi commented 10 years ago

phosphodiesterase 5a works in Explorer2

phophodiesterase 5a and phoshodiesterase 5a have typos, and don't give any result.

Von: ChristineChichester [mailto:notifications@github.com] Gesendet: 04 April 2014 10:40 An: openphacts/GLOBAL Betreff: Re: [GLOBAL] Text search not working (#22)

This is odd behavior because in the Open PHACTS API and the conceptwiki itself there are results for phoshodiesterase 5a...

Reply to this email directly or view https://github.com/openphacts/GLOBAL/issues/22#issuecomment-39543062 it on GitHub. https://github.com/notifications/beacon/94679__eyJzY29wZSI6Ik5ld3NpZXM6QmVh Y29uIiwiZXhwaXJlcyI6MTcxMjIyMDAwMCwiZGF0YSI6eyJpZCI6MjkyNjcyMTd9fQ==--4a4f0e 0219946f8f43981c481c6b821230413658.gif

leeharland commented 10 years ago

oops my bad. but point 2 still stands.

ianwdunlop commented 10 years ago

Exp 2 uses a static dump of compound and target names from the LDA cache. Nothing clever is used, no solr just 'does anything contain this string'. I agree that we need something better but I'm not sure concept wiki is the answer here either. I think we need a pure solr/elastic search based on compound/target/whatever name and description. So, if you type phosphodiesterase 5a and hit search it then uses the cw free text lookup to find any compounds/targets. The dropdown hints when you type something in is because people like that kind of thing. What they don't appreciate is that google have an entire server farm guessing for you, OPS has a mac mini and sqlite.

leeharland commented 10 years ago

ian - true and that is going to be on the agenda for the enso meeting, so we'll update this discussion after that (may 20 i think)

However, this git issue was more a gui thing - if there are no results can you just write a "no results found" line?

danidi commented 10 years ago

The results page now gives 0 Search Results Found. Can we close this issue?

leeharland commented 10 years ago

yup closing