Fields missing from patent call

openphacts / OPS_LinkedDataApi

A repository to host API configuration files, and code extensions

Other

9 stars 7 forks source link

Fields missing from patent call #17

Open madgpap opened 8 years ago

madgpap commented 8 years ago

e.g. http://ops2.few.vu.nl/1.5/patent?app_id=15a18100&app_key=528a8272f1cd961d215f318a0315dd3d&uri=http%3A%2F%2Frdf.ebi.ac.uk%2Fresource%2Fsurechembl%2Fpatent%2FUS-8877786-B2&_format=xml

occursInPatentTitle and occursInPatentAbstract are missing

ianwdunlop commented 8 years ago

According to the docs https://dev.openphacts.org/docs/develop these are optional fields (highlighted in yellow in the docs). Did you expect them to be there for this item?

madgpap commented 8 years ago

Hi Ian Thanks for the quick reply. According to the docs, there are a lot of optional fields which are still included in the response, such as occursInPatentDescription and occursInPatentClaims. For completeness, I would expect all the "occursIn..." attributes to be there for all the mentions in a patent.

ianwdunlop commented 8 years ago

Do you mean that even 'optional' fields that have no data should be in the response but be empty. eg. or that you think there should actually be data for those fields and that the API is missing something. Maybe @agaulton, @danidi or @antonisloizou would be able to comment better than me.

madgpap commented 8 years ago

It is the former. All the "occursIn..." boolean attributes should be present for each mention attribute of the API patent call. I hope it is clear now.

danidi commented 8 years ago

I wrote feedback on the call some time ago per email, it included the following:

It would be great to have an example patent where actually all of the places are at least mentioned once, to see how it would look like in the output. Or you could show the missing occursInPatent by also displaying them with the value ‘false’.