openphacts / OPS_LinkedDataApi

A repository to host API configuration files, and code extensions
Other
9 stars 7 forks source link

How should getDatasetProps($dataset_uri) properties be set? #24

Open randykerber opened 7 years ago

randykerber commented 7 years ago

Anyone know how these properties should be set?

It's at end of ./views/tsv.php

function getDatasetProps($dataset_uri) {
        $dataset_names = array (
                'http://linkedlifedata.com/resource/drugbank' => 'DrugBank',
                'http://ops.rsc-us.org' => 'OCRS',
                'http://purl.uniprot.org' => 'Uniprot',
                'http://purl.uniprot.org/enzyme' => 'EnzymeClassification',
                'http://www.conceptwiki.org' => 'ConceptWiki',
                'http://www.ebi.ac.uk/chebi' => 'ChEBI',
                'http://www.ebi.ac.uk/chembl' => 'ChEMBL',
                'http://www.geneontology.org' => 'GeneOntology',
                'http://www.openphacts.org/goa' => 'GOA',
                'http://www.wikipathways.org' => 'WikiPathways',
        );
        if (isset($dataset_names[$dataset_uri])){
                return $dataset_names[$dataset_uri];
        }
        return false;
}
danidi commented 7 years ago

This looks like the definitions for the provenance information in the header of the tsv output format of the API, e.g. https://beta.openphacts.org/2.1/compound?uri=http%3A%2F%2Fwww.conceptwiki.org%2Fconcept%2F38932552-111f-4a4e-a46a-4ed1d7bdf9d5&app_id=f91c5b2b&app_key=18a5d823d0e4933ac5fe22a3d52974c1&_format=tsv. However, the given example is wrong in some of the columns (DrugBank and OCRS are actually incorrectly attributed with ConceptWiki). Maybe because the wrong URI is set here? Looks like http://www.openphacts.org/bio2rdf/drugbank would be the URI for DrugBank, and http://ops.rsc.org would be the one for OCRS. http://aers.data2semantics.org/ is also not defined yet, should be AERS.