search

openpharma / brms.mmrm

R package to run Bayesian MMRMs using {brms}
https://openpharma.github.io/brms.mmrm/
Other
18 stars 2 forks source link

Enhance the FEV1 data comparison vignette #80

Closed wlandau closed 7 months ago

wlandau commented 7 months ago

This pull request proposes improvements the FEV1 data comparison vignette:

  1. Noticeably improve agreement between the Bayesian and frequentist models by:
    • Increasing the number of MCMC chains and iterations, and
    • Setting a diffuse prior on the intercept.
  2. Expand the prose, especially the conclusion at the end.
  3. Rename the vignette to fev1.Rmd to make room for a separate comparison vignette on the BCVA data.
  4. Tidy up code style.

@chstock, would you please review?

wlandau commented 7 months ago

Thanks for the review, @chstock! I believe I addressed your comments in recent commits.

chstock commented 7 months ago

Thanks for the review, @chstock! I believe I addressed your comments in recent commits.

Yes, definitely looks all good to me! Thanks!

wlandau commented 7 months ago

Yes, definitely looks all good to me! Thanks!

Awesome, thanks again for your review!