openpharma / clinsight

ClinSight - An application for medical monitoring within clinical trials
https://openpharma.github.io/clinsight/
Other
3 stars 0 forks source link

Fix database inconsistency warnings when saving a review of a form #134

Closed LDSamson closed 1 week ago

LDSamson commented 2 weeks ago

Fixes #108.

Verifications are now improved when saving a form review. Now the verifications and the update of the in-memory review data frame take into account that the review state might differ per item within a form, and thus that not all items need an update of the review state when saving a review.

jthompson-arcus commented 1 week ago

Actually it might be better to redo the PR as a direct merge to main, then we can merge main back into dev.

LDSamson commented 1 week ago

As discussed, I created a PR for the main branch that will fix this issue (#138 ). I will close this PR for now. We can probably use this commit to fix any merge issues with dev later on.