openpharma / crmPack

Object-Oriented Implementation of CRM Designs
https://openpharma.github.io/crmPack/
20 stars 10 forks source link

Feature Addition: "Classic" and "Information Theoretic" Decision Rules #122

Closed pc494 closed 2 years ago

pc494 commented 2 years ago

Summary Pavel has had fairly clean copies of these decision rules for some time now, I'm hoping to implement them in crmPack (a) because they are a nice addition and (b) as an opportunity to familiarise myself with structure of the code.

References

Additional Information I've copied over the template as a rough to do list, although I'm not sure how strictly I'll end up following it.

To do:

Prototype code: Check NextBestMinDist.txt Check NextBestInfTh.txt NextBestInfTh.txt NextBestMinDist.txt

pc494 commented 2 years ago

NextBestMinDist is already implemented (https://github.com/Roche/crmPack/blob/838781e6ef9a5afad10e006b365908b37c96d529/R/Rules-methods.R#L645) so I'll simply check that the implementation in the .txt matches as QA.

UPD: This implementation was fairly recent (late 2021) so I'm going to trust that it was tested at mergetime - moving on to NextBestInf