search

openpharma / crmPack

Object-Oriented Implementation of CRM Designs
https://openpharma.github.io/crmPack/
20 stars 10 forks source link

Use `McmcOptions` seed settings non-JAGS `mcmc` methods #190

Open wwojciech opened 2 years ago

wwojciech commented 2 years ago

In some methods, e.g.

setMethod("mcmc",
    signature = signature(
        data = "Data",
        model = "LogisticIndepBeta",
        options = "McmcOptions"
    ),
    ...
)

we use random sample generator other than JAGS, e.g. mvtnorm::rmvnorm. This sample generator does not take into account seed settings (rng_kind, rng_seed) in options of McmcOptions class. It should be decided how we influence R sample generator to use seed setting from options of McmcOptions class.

danielinteractive commented 2 years ago

@wwojciech yeah I guess it would be consistent to also use the settings in these cases.