openpharma / crmPack

Object-Oriented Implementation of CRM Designs
https://openpharma.github.io/crmPack/
20 stars 10 forks source link

Add appropriate indentation when `knit_print()` stopping rule list #837

Closed fenguoerbian closed 5 months ago

fenguoerbian commented 5 months ago

Padding spaces to the beginning when knit_print()ing StoppingList so that nested StoppingList will have appropriate indent levels when rendered.

Fixes #836

fenguoerbian commented 5 months ago

I've also updated this PR to address the nice-to-haves in #836

Puzzled-Face commented 5 months ago

I've also updated this PR to address the nice-to-haves in #836

Thank you. @danielinteractive I'm happy with this PR. Would you approve, please?

fenguoerbian commented 5 months ago

Just add some new testing code for knit_print() varying length stop lists

danielinteractive commented 5 months ago

here we cannot perform all the checks because it is a PR from a forked repo. Therefore merging