openpharma / mmrm

Mixed Models for Repeated Measures (MMRM) in R.
https://openpharma.github.io/mmrm/
Other
101 stars 17 forks source link

update confint #417

Closed clarkliming closed 5 months ago

clarkliming commented 5 months ago

close #414

add confint for the coefficients

update news, update vignettes to include confint for pairs on emmeans object.

github-actions[bot] commented 5 months ago

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  ----------------------------
R/between-within.R             59       0  100.00%
R/component.R                  67       0  100.00%
R/cov_struct.R                 97       1  98.97%   407
R/empirical.R                   7       0  100.00%
R/fit.R                       229       7  96.94%   186-189, 420, 481, 511
R/interop-car.R                70       2  97.14%   9, 48
R/interop-emmeans.R            39       0  100.00%
R/interop-parsnip.R            59       1  98.31%   12
R/kenwardroger.R               92       2  97.83%   41, 63
R/mmrm-methods.R              140       0  100.00%
R/residual.R                    8       8  0.00%    10-31
R/satterthwaite.R             116      12  89.66%   238-249
R/testing.R                    64       4  93.75%   29, 31, 80, 82
R/tidiers.R                    72       2  97.22%   46-47
R/tmb-methods.R               287       3  98.95%   277-278, 338
R/tmb.R                       281       0  100.00%
R/utils-formula.R              27       0  100.00%
R/utils-nse.R                  16       0  100.00%
R/utils.R                     184      12  93.48%   276-286, 456, 485
R/zzz.R                        70      24  65.71%   7-22, 55-60, 90, 118, 138
src/chol_cache.h               63       0  100.00%
src/covariance.h              101       1  99.01%   177
src/derivatives.h             126       0  100.00%
src/empirical.cpp              72       0  100.00%
src/exports.cpp                47       0  100.00%
src/jacobian.cpp               47       1  97.87%   54
src/kr_comp.cpp                56       0  100.00%
src/mmrm.cpp                   76       0  100.00%
src/predict.cpp                93       0  100.00%
src/test-chol_cache.cpp        58       5  91.38%   9, 18, 26, 55, 62
src/test-covariance.cpp       123       5  95.93%   9, 29, 40, 61, 72
src/test-derivatives.cpp      108       7  93.52%   44, 53, 62, 85, 94, 106, 124
src/test-utils.cpp            195       7  96.41%   9, 16, 24, 34, 44, 57, 119
src/testthat-helpers.h         15       5  66.67%   36-37, 41, 50, 53
src/utils.h                    84       0  100.00%
TOTAL                        3248     109  96.64%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  --------
R/mmrm-methods.R      +20       0  +100.00%
TOTAL                 +20       0  +0.02%

Results for commit: 5440a1edf31278ee05a7c411219d00c3fe8b2002

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 5 months ago

Unit Tests Summary

    1 files     44 suites   23s :stopwatch:   483 tests   445 :white_check_mark: 38 :zzz: 0 :x: 1 876 runs  1 833 :white_check_mark: 43 :zzz: 0 :x:

Results for commit 5440a1ed.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 5 months ago

Unit Test Performance Difference

Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | mmrm-methods | 👶 | | $+0.09$ | confint_give_same_result_as_SAS_on_ar1 | | mmrm-methods | 👶 | | $+0.09$ | confint_give_same_result_as_SAS_on_unstructured | | mmrm-methods | 👶 | | $+0.07$ | confint_give_same_result_as_emmeans_if_no_interaction_term | | mmrm-methods | 👶 | | $+0.04$ | confint_works_for_different_parm_input | | mmrm-methods | 👶 | | $+0.04$ | confint_works_for_different_significance_levels |

Results for commit 452efa0a3b0def9620a5cf326c539e628d34b876

♻️ This comment has been updated with latest results.

clarkliming commented 5 months ago

Thanks @clarkliming , nice work - can you please also add an integration test comparing with SAS results? (maybe addition to existing test)

Hi @danielinteractive I added some tests, but did not cover all the scenarios (only UN and AR1, on reml or ml), should be sufficient for now?