openpharma / mmrm

Mixed Models for Repeated Measures (MMRM) in R.
https://openpharma.github.io/mmrm/
Other
134 stars 23 forks source link

464: TMB warnings #466

Closed danielinteractive closed 2 months ago

danielinteractive commented 2 months ago

closes #464

github-actions[bot] commented 2 months ago

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  ----------------------------
R/between-within.R             59       0  100.00%
R/component.R                  69       0  100.00%
R/cov_struct.R                 97       1  98.97%   407
R/empirical.R                   7       0  100.00%
R/fit.R                       229       3  98.69%   420, 481, 511
R/interop-car.R               130       1  99.23%   9
R/interop-emmeans.R            51       0  100.00%
R/interop-parsnip.R            59       1  98.31%   12
R/kenwardroger.R               92       2  97.83%   41, 63
R/mmrm-methods.R              140       0  100.00%
R/residual.R                    8       0  100.00%
R/satterthwaite.R             116      12  89.66%   238-249
R/skipping.R                    8       0  100.00%
R/testing.R                    64       4  93.75%   29, 31, 80, 82
R/tidiers.R                    72       2  97.22%   46-47
R/tmb-methods.R               283       3  98.94%   279-280, 336
R/tmb.R                       296       0  100.00%
R/utils-formula.R              27       0  100.00%
R/utils-nse.R                  16       0  100.00%
R/utils.R                     207      12  94.20%   279-289, 437, 466
R/zzz.R                        72      26  63.89%   7-26, 59-64, 94, 122, 142
src/chol_cache.h               63       0  100.00%
src/covariance.h              101       1  99.01%   177
src/derivatives.h             126       0  100.00%
src/empirical.cpp              72       0  100.00%
src/exports.cpp                47       0  100.00%
src/jacobian.cpp               47       1  97.87%   54
src/kr_comp.cpp                56       0  100.00%
src/mmrm.cpp                   76       0  100.00%
src/predict.cpp                93       0  100.00%
src/test-chol_cache.cpp        58       5  91.38%   9, 18, 26, 55, 62
src/test-covariance.cpp       123       5  95.93%   9, 29, 40, 61, 72
src/test-derivatives.cpp      108       7  93.52%   44, 53, 62, 85, 94, 106, 124
src/test-utils.cpp            195       7  96.41%   9, 16, 24, 34, 44, 57, 119
src/testthat-helpers.h         15       5  66.67%   36-37, 41, 50, 53
src/utils.h                    78       0  100.00%
TOTAL                        3360      98  97.08%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
R/tmb.R          +1       0  +100.00%
R/utils.R        +8       0  +0.23%
R/zzz.R          +2      +2  -1.83%
TOTAL           +11      +2  -0.05%

Results for commit: 26246543747013bc7ed5632f527ce9e90c237308

Minimum allowed coverage is 80%

:recycle: This comment has been updated with latest results

github-actions[bot] commented 2 months ago

Unit Test Performance Difference

Additional test case details | Test Suite | $Status$ | Time on `main` | $±Time$ | Test Case | |:-----|:----:|:----:|:----:|:-----| | utils | 👶 | | $+0.02$ | h_tmb_warn_optimization_works_as_expected |

Results for commit 673cde8a87e6ccf5eca8718499ce67a2199047ce

♻️ This comment has been updated with latest results.

danielinteractive commented 2 months ago

@clarkliming this would be ready for review now since TMB has been updated on CRAN

github-actions[bot] commented 2 months ago

Unit Tests Summary

    1 files     46 suites   26s :stopwatch:   506 tests   466 :white_check_mark: 40 :zzz: 0 :x: 1 956 runs  1 910 :white_check_mark: 46 :zzz: 0 :x:

Results for commit 26246543.

:recycle: This comment has been updated with latest results.

danielinteractive commented 2 months ago

@cicdguy Hi Dinakar, quick question, how would we get the latest CRAN version of the package TMB installed here during the check? Just wait a bit or do we need to trigger that somehow?

cicdguy commented 2 months ago

@danielinteractive - one way to override is by adding the package to the staged.deps config.

Another thing I can do is to rebuild the image which will have the new version of TMB installed. I can do that right now.

danielinteractive commented 2 months ago

That would be great, thanks @cicdguy !

cicdguy commented 2 months ago

Can you try now? New image has the latest version of TMB. You might need to push a new commit.

danielinteractive commented 2 months ago

Thanks a lot @cicdguy , @clarkliming can you have a quick look if everything is fine?