search

openpharma / simaerep

simulate adverse event reporting in clinical trials with the goal of detecting under-reporting sites.
https://openpharma.github.io/simaerep/
Other
21 stars 5 forks source link

Upstream #49

Closed fcollinbi closed 4 months ago

fcollinbi commented 5 months ago

Added parameter 'under_only', which is FALSE by default. If set to TRUE, bootstrapping is applied to all sites, inlcuding sites with average AE rates below study average. Plot and vignett have to be updated for changes.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.36%. Comparing base (4f8752a) to head (773d585).

:exclamation: Current head 773d585 differs from pull request most recent head aa0c8a7. Consider uploading reports for the commit aa0c8a7 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #49 +/- ## ========================================== + Coverage 93.35% 93.36% +0.01% ========================================== Files 7 7 Lines 1535 1538 +3 ========================================== + Hits 1433 1436 +3 Misses 102 102 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

erblast commented 4 months ago

Hi Frederik, wolltest du den force push commit wirklich machen? Bei e6ca6a2 war doch alles in Ordnung, hab nur am Freitag nicht mehr dran gedacht zu schauen ob der test durch ist. Force Push ist selten ne gute idee, da ist jetzt viel alter code dabei. Kannst du wieder auf den alten commit zurück? Vielleicht ists einfacher wenn du nen neuen PR auf machst.

fcollinbi commented 4 months ago

Hi Björn,

Sorry, da ist was schief gegangen. Wollte definitiv keinen force push commit machen. Wie kann ich das ab besten rückgängig machen ? Neuer push commit?

VG Frederik

fcollinbi commented 4 months ago

Aktuellste Version von simaerep:master ist nun mit upstream gemerged.

fcollinbi commented 4 months ago

Ich schließe diesen pull request und mache einen neuen auf.