openpharma / simaerep

simulate adverse event reporting in clinical trials with the goal of detecting under-reporting sites.
https://openpharma.github.io/simaerep/
Other
21 stars 5 forks source link

make multiplicity correction optional and remove eval_sites_deprecated() #62

Open erblast opened 5 days ago

erblast commented 5 days ago

eval_sites_deprecated() was rewritten as p_adjust_bh_inframe() which works using only table operations. These two unit tests were added to confirm correct implementation:

eval_sites_deprecated() deprecated can be removed. It used to be the default when method = NULL was passed to eval_sites().

Now when method = NULL | NA | "None" | None is passed to eval_sites no multiplicity correction will be done.

erblast commented 5 days ago

new unit test: "simaerep() with mult_corr = FALSE must not return adjusted probabilities"