search

openpharma / staged.dependencies

R package to implement development stages for package development
https://openpharma.github.io/staged.dependencies/
MIT License
12 stars 3 forks source link

When using renv suggests packages are not installed #163

Open nikolas-burkoff opened 2 years ago

nikolas-burkoff commented 2 years ago

renv::install only installs Depends, Imports and LinkingTo not Suggests https://github.com/openpharma/staged.dependencies/blob/669f45a95d8772899551ad51fc3b38a3b5a1056a/R/git_tools.R#L188

This is a gap compared to using staged.deps without renv where remotes::install_deps allows you to do it

We should move packages around so things are installed to make renv/not renv behaviour consistent https://github.com/openpharma/staged.dependencies/blob/669f45a95d8772899551ad51fc3b38a3b5a1056a/R/git_tools.R#L185

nikolas-burkoff commented 2 years ago

See https://github.com/rstudio/renv/issues/933#issuecomment-1198036889

nikolas-burkoff commented 1 year ago

See https://github.com/rstudio/renv/issues/1087

nikolas-burkoff commented 1 year ago

The renv issue above has been fixed so once it has been released we can 1) Set the renv version in our description file >= 0.17.0 2) This https://github.com/openpharma/staged.dependencies/blob/main/R/git_tools.R#L201 needs a "..." argument added and should automatically pick up the new dependencies argument in renv::install 3) Docs e.g. here and here should be updated 4) Update ticket here - so the vignette can show how to handle external package installation when using renv