search

openpipelines-bio / openpipeline

https://openpipelines.bio
MIT License
25 stars 11 forks source link

Add genetic demultiplexing component #343

Closed rcannood closed 6 months ago

rcannood commented 1 year ago

Copy of #165.

Please check when the following items have been completed:

DriesSchaumont commented 11 months ago

@wxicu During the openpipelines meeting of 2023.05.24 (see also the meeting notes), it was decided to close this PR pending the resolution of some issues. This PR may be close to merging, but I suggest to keep working on it in a branch and to re-open the PR when things are ready. Please ping if you have any questions!

rcannood commented 6 months ago

Hey @wxicu !

For me this PR is ok to merge!

Would you like to review the last few changes I made?

Also, the changes I made to the demuxlet component could be ported to the freemuxlet component, if you like. I also noticed that demuxlet outputs AMB and DBL whereas freemuxlet outputs unassigned and doublet. Which do you think is correct?

wxicu commented 6 months ago

Sorry for my late update, and big thanks to @rcannood for helping in resolving the problems. I have also changed the freemuxlet component by merging into one r script. Both AMB and unassignded are correct, but here it is better to make a consensus so I stick to the one of demuxlet.

DriesSchaumont commented 6 months ago

Perfect, these are great contributions! Thanks a lot to you both 🎉