Closed VladimirShitov closed 11 months ago
@VladimirShitov Good catch! Would you be able to implement tests?
Added test and fixed small comments. The function for HVG subsetting is now moved to a separate utils script, as it is used in other components as well. The problem is that the test pipeline fails because there is "No space left on device", so I'm not 100% sure that importing utils works correctly
@VladimirShitov The disk issue seemed like a temporary one (?). I am now getting this:
Yep, this is a problem from my side now 😅 Fixing
Fixed it :) @DriesSchaumont , can you check?
@VladimirShitov Could you adress the comment from Robrecht?
Done, please check :)
LGTM! @rcannood If you would like to have a look
Changelog
This line in scvi integration component is supposed to subset highly-variable genes:
adata = adata[:,adata.var['var_input']].copy()
However, this will not happen for the following reasons:
par["var_input"]
should be usedadata.var[key]
will return a column fromadata.var
and not the list of selected genes as expectedThis PR fixes the issue
Checklist before requesting a review
[x] I have performed a self-review of my code
[ ] Conforms to the Contributor's guide
Check the correct box. Does this PR contain:
[ ] Proposed changes are described in the CHANGELOG.md
[ ] CI tests succeed!