Feature/cellxgene census update - Githubissues

openpipelines-bio / openpipeline

https://openpipelines.bio

MIT License

25 stars 11 forks source link

Feature/cellxgene census update #520

Closed MatthiasBeyens closed 8 months ago

MatthiasBeyens commented 8 months ago

Changelog

... Describe your changes ...

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] Conforms to the Contributor's guide
Check the correct box. Does this PR contain:
- [ ] Breaking changes
- [ ] New functionality
- [x] Major changes
- [ ] Minor changes
- [ ] Bug fixes
[x] Proposed changes are described in the CHANGELOG.md
[x] CI tests succeed!

MatthiasBeyens commented 8 months ago

@DriesSchaumont once CI tests ran successfully, could you include current PR along the scheduled 0.10.0 release? Much appreciated! ;-)

rcannood commented 8 months ago

Hey Matthias! Thanks for the update!

The biggest changes in this PR is that the different arguments have been replaced with simply a query that one needs to provide, correct?

This assumes that the user knows exactly how to build such a query and what the format of cell census is.

Is this not an issue? Might it be a good idea to have a few arguments which will add extra terms to the query?