search

openpipelines-bio / openpipeline

https://openpipelines.bio
MIT License
25 stars 11 forks source link

Wrong memory assignment #556

Closed ddemaeyer closed 7 months ago

ddemaeyer commented 7 months ago

https://github.com/openpipelines-bio/openpipeline/blob/c4b39e32f9da10efb54ac3c85985b47f83f873f8/target/nextflow/annotate/popv/main.nf#L2597-L2601

Currently the memory requirements are multiplied by 1024 as in byte times, this has however changed. Requesting 500Gb of memory will now result in e.g. 520Gb being reserved. Based on the new standards the multiplication should be done by thousands.

Currently the standard is 1 Gigabyte (GB) = 1000 Megabytes (MB). B
ut it wasn't always like that. For a long time, 1 Kilobyte=1024 bytes, 1 Megabyte = 1024 kilobytes, 1 Gigabyte = 1024 megabytes, and so on. 
The reason being the fact that it easier to do binary math when working with powers of two.
DriesSchaumont commented 7 months ago

@rcannood could you transfer this issue to the Viash repository? Thanks!

DriesSchaumont commented 7 months ago

I moved this issue upstream.