openpipelines-bio / openpipeline

https://openpipelines.bio
MIT License
25 stars 11 forks source link

Rework mitochondrial gene detection #585

Closed DriesSchaumont closed 6 months ago

DriesSchaumont commented 7 months ago

Changelog

The detection of mitochondrial genes has been revisited in order to remove the interdependency with the count filtering and the QC metric calculation.

Issue ticket number and link

Partially closes #554 (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

DriesSchaumont commented 7 months ago

Good idea to move it to a separate qc pipeline!

Did you run the integration tests?

Also, minor comment on the viash config.

I did run them locally, but I will run them on Actions to see if the resources are correctly defined in the config.

DriesSchaumont commented 6 months ago

Integration tests are working (timeout one is unrelated): https://github.com/openpipelines-bio/openpipeline/actions/runs/6547966983/job/17848202447